AutoSizeRows on TAdvStringGrid not taking scaling in account?

Forder_Stefan1 · February 20, 2024, 9:07am

I am using the TAdvStringGrid and just upgraded from the old GridPack to the latest VCL UI Pack.
I am observing, that AutoSizeRow is no longer accurately sizing the row heights when there is scaling applied to the form. (e.g. manually by ScaleBy(5,2); )

In a fresh test project, I compared the result old vs new:

Is there something I can do or is it an issue with the AutoSizeRows/Columns ??

OS: Windows 11
IDE: C++Builder Tokyo 10.2.3

Testproject:
GridTest.zip (129.0 KB)

Thanks

brunofierens · February 20, 2024, 5:08pm

What is the DPI of the screen you are running this on?

Forder_Stefan1 · February 21, 2024, 7:10am

I was running it on default 96 dpi.

But I can also see the same behaviour when not manually scaling but moving the app to a monitor with 200% scaling (scaling set in the windows screen configuration).

Only when there is no scaling at all, the row looks fine.

brunofierens · February 21, 2024, 9:49am

I have retested with a default grid on the form initialized with:

procedure TForm1.FormCreate(Sender: TObject);
begin
  advstringgrid1.DefaultRowHeight := 48;
  advstringgrid1.RandomFill(false);
end;

procedure TForm1.Button1Click(Sender: TObject);
begin
  advstringgrid1.AutoSizeRows(false);
end;

I perform this on a 100% DPI screeen, 200% DPI screen: no issue can be seen

I perform this when starting the app on the 200% DPI screen, move it to the 100% DPI screen and perform AutoSizeRows() and vice versa : no issue can be seen

I move the app before and after resizing from 100% to 200% screen and vice versa : no issue can be seen

I tested this both with Delphi 10.2 and Delphi 12.

Forder_Stefan1 · February 21, 2024, 1:50pm

Hmm, also with your table data code, and a fresh placed grid I still have the issue.
The same when using C++Builder 12.

To be precise: the row is shrinked when calling AutoSizeRows, but the padding on the bottom of each row is still about double the padding on the top of the row.
This makes the table listings considerably larger than necessary.

Can there be a difference between C++ and Delphi test projects?
Could you share your test-project with the binary?

Thanks

brunofierens · February 21, 2024, 3:38pm

I extended the test with showing the calculated row height

procedure TForm1.Button1Click(Sender: TObject);
begin
  advstringgrid1.AutoSizeRows(false);
  caption := advstringgrid1.RowHeights[1].ToString;
end;

in 100% DPI, the result here is 22
in 150% DPI, the result here is 33
in 200% DPI, the result here is 44

this looks the expected result to me.

Forder_Stefan1 · February 22, 2024, 1:49pm

The numbers may look nice, but the visual layout doesn't. The Row is not shrunk to the Text height.

Currently, I get the expected result, when calculating and setting the row heights manually (under certain assumpsions)

grid1->RowHeights[iRow] = grid1->Canvas->TextHeight("gh");

But that shouldn't be necessary.

Row sizing by AutoSizeRow:

Row sizing by TextHeight