Issue with OnDblClickCell event of TWebStringGrid

WEB TMS WEB Core
1

We just installed TMS Web Core 2.7.2.0 and found that the OnDblClickCell event has been implemented for TWebStringGrid component now. Thank you for that.
Unfortunately, the method TCustomStringGrid.HandleDoDblClick is too restrictive by checking the target element for tagName TD or TH, since the innerHTML of a TD or TH might be further styled with a DIV, SPAN aso. We therefore propose to also check the parent hierarchy of the target element to be a TD or TH until a parent is nil, the parent is the grid element itself or it is an TD or TH:

  el := Event.targetElement;
  while Assigned(el) and (el <> Self.ElementHandle) and
        not ((el.tagName = 'TD') or (el.tagName = 'TH')) do
    el := el.ParentElement;
  if Assigned(el) and ((el.tagName = 'TD') or (el.tagName = 'TH')) then
...
2

We will review this suggestion and consider it for the next release.

3

We just installed TMS Web Core 2.7.2.2 and found that this fix has been applied. Thank you. Nevertheless, the code of the if statement has not been completely applied. Since "and" binds more than "or", I think the parentheses around the or conditions must stay there, but have been removed in the unit WEBLib.Grids.pas, line 3116 of TMS Web Core 2.7.2.2.

4

You are correct about this and we applied this.