Bug in 2.5.2 Uppercase/Lowercase in Javascript (asm-code)

WEB TMS WEB Core
1

I haven't tested it with 2.5.4. I'm still working with 2.5.2

I found a few places in Unit Core Source/WEBLib.WebCtrls.pas where the capitalization is wrong.
For example, line 3995
Parameter: "Event: TJSEvent"
is used as "event" (with a lowercase "e")

There are several places in this unit where "Event" is wrong.

Can you please check whether there are any other errors? Perhaps in other units?

function TFile.HandleFileLoadAsBase64(Event: TJSEvent): boolean;
var
  s: string;
  ctrl: TComponent;
begin
  Result := true;

  asm
    function _arrayBufferToBase64( buffer ) {
    var binary = '';
    var bytes = new Uint8Array( buffer );
    var len = bytes.byteLength;
    for (var i = 0; i < len; i++) {
        binary += String.fromCharCode( bytes[ i ] );
    }
    return window.btoa( binary );
    }
    s = _arrayBufferToBase64(event.target.result);  // <---
  end;

Thomas

2

We revised this. Next update will address this.